Fix handling of circular MOVED redirects in cluster slot mapping #3899
+77
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. In case there are security findings, they will be communicated to you as a comment inside the PR. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
… the redirected node is already the shard primary.
barshaul
force-pushed
the
circular_moved
branch
from
d6c72b1 to
5361dc1
Compare
Collaborator
|
Hi @barshaul, thank you for your contribution. We will review it soon. |
Contributor
Author
Thanks |
petyaslavova
reviewed
Jan 8, 2026
barshaul
force-pushed
the
circular_moved
branch
from
c446c1e to
b2b314b
Compare
Contributor
Author
|
@petyaslavova ready for another round |
petyaslavova
approved these changes
Jan 16, 2026
Collaborator
petyaslavova
left a comment
petyaslavova
left a comment
There was a problem hiding this comment.
LGTM. Thank you @barshaul !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Circular MOVED responses were incorrectly treated as failover events, causing the
primary node to be demoted and leaving shards with replicas only.
This can occur in DNS-based environments where a MOVED response intentionally
points back to the same address (e.g., MOVED + disconnect to force DNS re-resolution).
This change detects circular MOVED redirects and avoids updating the slot map
when the redirected node is already the shard primary.
Pull Request check-list
Please make sure to review and check all of these items: